Open
Conversation
titzer
reviewed
Jan 8, 2026
| VALUE_SLOT_SIZE = 32 | ||
| TAG_TO_VALUE_OFFSET = 16 | ||
|
|
||
| FRAME_FIELDS = { |
Owner
There was a problem hiding this comment.
Nice. Can we make a little utility that when run uses the layout description to generate this part of the file? Then it could be part of the make system and automatically update this file.
Contributor
Author
There was a problem hiding this comment.
Should this be done with a Virgil script that includes the rest of Wizard as a dependency in order to get the offsets and tag configurations?
Owner
There was a problem hiding this comment.
Yes. A file like gdbgen.main.v3 that can be run to output the constants should suffice. Or it could be an option to the main wizeng binary to dump out the constants.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR cleans up the
.gdb_initscript and adds thevsregcommand to print the value stack when given%vspand%vfp(used in place ofvsframein SPC mode as the value stack bounds are not synced to the interpreter frame).