Optimize airport lookups from O(n) to O(1)

[Copilot]

IATA and ICAO code lookups were scanning all 6,076 airports linearly. Invalid lookups took 558ms per 1000 iterations.

Changes

IATA lookups - Direct hash access via existing parsed_data structure

# Before: O(n) scan
all.find { |airport| airport.iata == iata_code }

# After: O(1) lookup
parsed_data[iata_code]

ICAO lookups - New cached hash index

def self.icao_index
  @icao_index ||= parsed_data.values.each_with_object({}) do |airport_data, index|
    index[airport_data["icao"]] = airport_data
  end
end

icao_codes method - Added memoization to avoid rebuilding array on each call

Performance

Operation	Before	After	Improvement
IATA (invalid)	558ms	0.13ms	4292x
ICAO (invalid)	555ms	0.14ms	3964x
icao_codes	624ms	8ms	78x

Memory overhead: ~1.4MB for ICAO index (matches existing parsed_data size)

Original prompt

Audit for potential performance improvements and apply fixes

Created from VS Code via the GitHub Pull Request extension.

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.