Replace O(n) linear search with O(1) hash lookups in airport finder methods

[Copilot]

Performance audit identified unnecessary linear searches across 6,076 airports in frequently-called lookup methods.

Changes

find_by_iata_code - Direct hash access instead of iterating through all

• parsed_data is already keyed by IATA code
• ~9x speedup (0.033s → 0.0037s per 1000 lookups)

find_by_icao_code - Added icao_index hash for O(1) lookups

• Lazily builds ICAO → airport_data mapping
• ~9x speedup (0.0329s → 0.0036s per 1000 lookups)

icao_codes - Memoized array generation

• Was rebuilding 6,076-element array on every call
• Now cached after first access

# Before: O(n) scan through all airports
def self.find_by_iata_code(iata_code)
  all.find { |airport| airport.iata == iata_code }
end

# After: O(1) hash lookup
def self.find_by_iata_code(iata_code)
  return unless iata_code.length == 3
  airport_data = parsed_data[iata_code]
  return unless airport_data
  airport_from_parsed_data_element(airport_data)
end

All existing tests pass. No API changes.

Original prompt

Audit for potential performance improvements and apply fixes

Created from VS Code via the GitHub Pull Request extension.

---

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.