Open
Conversation
Contributor
dbrakenhoff
commented
Mar 27, 2026
- add unified Calibration class that supports both steady and transient models
- add support for constants and time shifts for head observations
- ensure steady transmissivities are updated in initialize
- use inhomdict in steady models and support names
- improve aquifer summaries by using named columns instead of iloc indexing
- add print time info to tmin_warning in invlapcomp
- add example notebook to test new class
- add unified Calibration class that supports both steady and transient models - add support for constants and time shifts for head observations - ensure steady transmissivities are updated in initialize - use inhomdict in steady models and support names - improve aquifer summaries by using named columns instead of iloc indexing - add print time info to tmin_warning in invlapcomp - add example notebook to test new class
- Aquifers initialize method calls inhom.create_elements() - this ensures all aquifer/inhom data is known prior to creating inhom elements
Contributor
Author
|
This PR introduces a breaking change, the inhomlist has been replaced by an inhomdict in |
There was a problem hiding this comment.
Pull request overview
This PR introduces a unified calibration framework intended to support both steady-state and transient timflow models (including shared/joint parameters), while also standardizing inhomogeneity handling (inhomdict) and improving aquifer summaries and some messaging.
Changes:
- Added
timflow.calibrate.Calibrateas a new unified calibration API, and exported it fromtimflow.__init__. - Replaced list-based inhomogeneity handling with
inhomdictusage across steady/transient models and plotting, and updated summaries to use named columns. - Improved transient inverse Laplace warning output and updated a benchmark notebook for the new inhomogeneity access pattern.
Reviewed changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated 15 comments.
Show a summary per file
| File | Description |
|---|---|
| timflow/transient/invlapnumba.py | Improves tmin warning printout by including offending time and interval info. |
| timflow/transient/inhom1d.py | Removes redundant initialize() override so element creation can be driven centrally. |
| timflow/transient/aquifer.py | Makes aquifer summary column handling more robust and ensures 2-pass inhom init/element creation. |
| timflow/steady/model.py | Updates inhomogeneity iteration and summaries to use inhomdict and inhom names. |
| timflow/steady/inhomogeneity1d.py | Adjusts naming initialization to rely on aquifer add_inhom() naming logic. |
| timflow/steady/inhomogeneity.py | Adds optional name support to polygon inhomogeneities and forwards it in constructors. |
| timflow/steady/aquifer.py | Recomputes transmissivity on initialize, switches to inhomdict, and improves summary indexing. |
| timflow/plots/plots.py | Unifies cross-section inhomogeneity plotting by iterating aq.inhomdict.values(). |
| timflow/calibrate.py | Adds new unified calibration implementation (steady/transient, shared parameters, time shifts/constants). |
| timflow/init.py | Exports the new unified Calibrate at package top level. |
| docs/steady/04benchmarks/test_polygon_areasink.ipynb | Updates notebook to access inhomogeneity via inhomdict and adds an empty cell. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
- allow negative log scaled parameters - fix some typos - allow adding constants and time shifts to head in well time series - raise when adding time series but no transient model is defined, and when steady observations are added but no steady model is provided - ensure nan-filling in residuals is done for transient calculations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.