Skip to content

core: let cq_next pollset work first #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
overvenus wants to merge 1 commit into
base: rs-release
Choose a base branch
from
Draft

core: let cq_next pollset work first #52

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions src/core/lib/surface/completion_queue.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -986,6 +986,26 @@ static grpc_event cq_next(grpc_completion_queue* cq, gpr_timespec deadline,
for (;;) {
grpc_millis iteration_deadline = deadline_millis;

/* Attempting a 0-timeout poll first, send and receive eagerly.
*/
if (cqd->queue.num_items() % 2 == 0) {
gpr_mu_lock(cq->mu);
cq->num_polls++;
grpc_error_handle err = cq->poller_vtable->work(
POLLSET_FROM_CQ(cq), nullptr, 0);
gpr_mu_unlock(cq->mu);

if (err != GRPC_ERROR_NONE) {
gpr_log(GPR_ERROR, "Completion queue next failed: %s",
grpc_error_std_string(err).c_str());
GRPC_ERROR_UNREF(err);
ret.type = GRPC_QUEUE_TIMEOUT;
ret.success = 0;
dump_pending_tags(cq);
break;
}
}

if (is_finished_arg.stolen_completion != nullptr) {
grpc_cq_completion* c = is_finished_arg.stolen_completion;
is_finished_arg.stolen_completion = nullptr;
Expand Down