Refactor brush input handling and ignore interactions over egui elements#28
Merged
tigerplush merged 2 commits intotigerplush:mainfrom Apr 30, 2025
Merged
Conversation
c26f59d to
39af74e
Compare
Owner
|
@Megabjarne Very nice! Do you think we could do without the I was thinking that it's a very complex function already and maybe we could redesign it? I definitely want to remove |
tigerplush
approved these changes
Apr 29, 2025
Contributor
Author
|
I can see if i can restructure it to split and simplify it, would be benefitial for when more features are added later as well 👍 |
39af74e to
1763a86
Compare
1763a86 to
5a6044d
Compare
Contributor
Author
|
Okay, separate system for registering inputs, that creates the higher level input events which are then used in the actual brush handler |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before, if clicking somewhere on the brush selection toolbar, or on the egui inspector window, the brush system would still run and process the pointer event, leading to unintended dig designations.
Not sure if this approach is best practice, could do it with a run_if as well if that is more idiomatic