segment ebuf can be pre-allocated for better performance#23
Open
yihuang wants to merge 1 commit intotidwall:masterfrom
Open
segment ebuf can be pre-allocated for better performance#23yihuang wants to merge 1 commit intotidwall:masterfrom
yihuang wants to merge 1 commit intotidwall:masterfrom
Conversation
semihbkgr
reviewed
Jan 1, 2024
semihbkgr
left a comment
There was a problem hiding this comment.
The size check, determining whether the buffer size exceeds the SegmentSize, is applied after appending the new entry data to the buffer.
var epos bpos
s.ebuf, epos = l.appendEntry(s.ebuf, b.entries[i].index, data)
s.epos = append(s.epos, epos)
if len(s.ebuf) >= l.opts.SegmentSize {
// segment has reached capacity, cycle nowWhen the buffer size surpasses its capacity, it re-allocates memory to fit the underlying array.
Therefore, to fully leverage pre-allocation, I think we should ensure that the buffer's capacity is not exceeded.
Author
|
the previous behavior allows the segment surpasses its capacity once with the last entry, and we don't have a limit of the size of an entry, it's not easy to preallocate for that I think. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the number of allocations are clearly dropped, cpu time is also improved marginally.