Correct path compression collapse in delete_key#19
Open
parazyd wants to merge 1 commit intothyeem:masterfrom
Open
Correct path compression collapse in delete_key#19parazyd wants to merge 1 commit intothyeem:masterfrom
parazyd wants to merge 1 commit intothyeem:masterfrom
Conversation
Delete failed to merge path bits when collapsing soft nodes, causing root hash mismatches. I've added the BitsOwned struct for owned bit paths with optimized byte-level merging, and updated delete_key() to properly collapse through soft nodes and inline them when rebuilding hard nodes. Performance should be comparable to original, and lookups might in fact be improved since we eliminate unnecessary soft node indirection.
Author
|
This patch is related to #18 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Delete failed to merge path bits when collapsing soft nodes, causing
root hash mismatches.
I've added the BitsOwned struct for owned bit paths with optimized
byte-level merging, and updated delete_key() to properly collapse
through soft nodes and inline them when rebuilding hard nodes.
Performance should be comparable to original, and lookups might in
fact be improved since we eliminate unnecessary soft node indirection.