Skip to content

Fix hover styles for base-button when rendering links#242

Merged
davinotdavid merged 1 commit intomainfrom
fix-hover-styles-for-button-links
Mar 23, 2026
Merged

Fix hover styles for base-button when rendering links#242
davinotdavid merged 1 commit intomainfrom
fix-hover-styles-for-button-links

Conversation

@davinotdavid
Copy link
Copy Markdown
Contributor

@davinotdavid davinotdavid commented Mar 23, 2026

Description of the Change

  • Since :enabled only works for form elements, updated them all to :not(:disabled) instead which should be equivalent

Benefits

  • Hover effects on buttons should now work when they are rendered as links

GIF

Mar-23-2026 17-29-23

Related tickets

Fixes #241

@davinotdavid davinotdavid merged commit 226b543 into main Mar 23, 2026
3 checks passed
@davinotdavid davinotdavid deleted the fix-hover-styles-for-button-links branch March 23, 2026 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BaseButton (all buttons) hover styles don't work when an <a> is rendered instead of <button>

2 participants