Merged
Conversation
|
does it matter if |
Collaborator
@hellsworth No. Quotes are only needed in very rare cases, where the font name is the same as a reserved keyword (like e.g. 'inherit' or 'serif'). Normally there shouldn't be any issues by omitting quotes for font family names at all. |
devmount
approved these changes
Mar 20, 2026
Collaborator
devmount
left a comment
devmount
left a comment
There was a problem hiding this comment.
Great catch, thanks @radishmouse! (and sorry if it was me who put those quotes there in the first place 😂 )
Contributor
Author
Totally ok to use single or double quotes. Per @devmount , they're not strictly needed (but I usually see them around specific font names). |
|
Cool. do whatever you think is appropriate. I'm so not a web dev so I defer to you guys 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #239
Description of the Change
Removes the quotes from
sans-serif, which is a generic font and does not need quotes.As reported here, adding the quotes cause a delay in rendering with correct font properties.
Benefits
Fixes flash of unstyled text for some services-ui elements.
Related tickets
Originally reported here: thunderbird/roadmaps-overview#21