Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue 1
tutor_update_course_content_orderwhich allows to change the order of the lesson inside a topic, a payload can be passedtutor_topics_lessons_sortingwhich takes topic_id and array of lesson idtutor_topics_lessons_sortingon whether the user can edit the topic, thus allowing subscribers to modify topic id, add other lessons etc.tutor_utils()->can_user_manage( 'topic', id );Issue 2
For both
enroll_nowandcourse_enrollmentmethod insideCourse.phpclass there is check whether the course is paid course but there is not check whether the course is private, thus users can enroll in private courses through ajax call.To fix this i have added private courses check on both of the methods.