Fix Save Layout when showSaveFilePicker is unsupported#378
Open
ishyv wants to merge 1 commit intothe-via:mainfrom
Open
Fix Save Layout when showSaveFilePicker is unsupported#378ishyv wants to merge 1 commit intothe-via:mainfrom
ishyv wants to merge 1 commit intothe-via:mainfrom
Conversation
Prefer File System Access API when available, but fall back to a Blob download so Save Layout works in unsupported/blocked contexts. Only treat AbortError as a real user cancel.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Saving the current layout relied on the File System Access API (
window.showSaveFilePicker). In browsers/contexts where that API is unsupported or blocked, the call fails before showing any prompt. The previous implementation caught all errors and logged "user cancelled", which hid the real failure and prevented saving entirely.Fix
showSaveFilePickerwhen availableAbortErroras a real user cancel<a download>) otherwiseRepro
Before: no prompt + no file saved (misleading "user cancelled" log).
After: layout downloads as a
.layout.jsonfile.