Open
Conversation
97b5dd8 to
b6acc1f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixed valid checking for keycodes in some situations
When using a hex value in custom key
any, only accept hex formed string in range of0x0000and0xffff, including leading zero value and non leading zero valueDim the unsupported keys in select area and block click actions, it is a previously built function and disabled due to the bug

When selecting an unsupported keycode (if possible), block the applying action.
Before the changes, it will apply with keycode
0(aka.KC_NO)When applying a saved layout which includes unsupported keycodes, replace them with


KC_NO, port error message to console and list them on web pageThere is no message output before changes.
Fix keycode checking for mod combo keys in
Anyapp/src/utils/advanced-keys.ts
Line 397 in 892ee1b
The
findmethod returnsnullfor invalid keycodes andif (null)equals toif (false)in this case