Use docker for building/running the via app#209
Open
flori wants to merge 7 commits intothe-via:mainfrom
Open
Conversation
antonkesy
approved these changes
Dec 15, 2023
antonkesy
left a comment
antonkesy
left a comment
There was a problem hiding this comment.
LGTM
might be a good idea to also include some information in the documentation on "how to run the container"
flori
force-pushed
the
use-docker-for-building-and-running-via-app
branch
from
cf55267 to
d78bed3
Compare
flori
force-pushed
the
use-docker-for-building-and-running-via-app
branch
4 times, most recently
from
b1d6664 to
66cb710
Compare
and modify npm start command. - Update `FROM node:21-alpine` to `FROM node:23-alpine`. - Update `RUN sed -i ... package.json` to replace `vite --force` with `vite --force --host`. - Update `CMD [ "npm", "start" ]` to `CMD [ "npm", "run", "dev" ]`.
to use 'unless-stopped' restart policy.
- Updated base image from `node:23-alpine` to `node:24-alpine` - This changes the Node.js version used for building and running the application - The Alpine Linux variant is maintained for minimal image size
- Added detailed instructions for running the application with Docker Compose - Included steps for starting, accessing, and stopping the application - Documented the Docker Compose configuration with Node.js **24-alpine** Alpine image - Added build instructions with `docker compose build --no-cache` - Mentioned automatic restart policy and optimized development environment
- Added `/dist` directory to `.dockerignore` file to prevent it from being included in Docker builds - This ensures that compiled distribution files are not part of the container image - The change helps keep container images smaller and cleaner by excluding build artifacts
flori
force-pushed
the
use-docker-for-building-and-running-via-app
branch
from
00e6e58 to
4b7410a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This might be useful for people that want to build and run the via app without having to install the dependencies directly on their local machine rather than just using the official web site.