Show tooltips for keys with a shortName#188
Open
kyleshay wants to merge 1 commit intothe-via:mainfrom
Open
Conversation
Author
|
I just came across #175/#105 — I guess we'd need to coordinate on what's desired here. That PR ends up effectively doing the same (but ends up making every single key have a tooltip.) Maybe it ends up being something similar to the little bar that's shown on hover in the key list frame so you're not spammed w/ tooltips, eg: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Hi! This diff is just a suggestion, feel free to close if you like.
I noticed that tooltips are only being shown today, but only sometimes — for example, if a key name doesn't fit within the key cap.
It's not always intuitive (for a beginner like myself) to know what all of the short hand names map to.
This diff just always shows tooltips for items that have a
shortNamespecified insrc/utils/key.ts. It's a bit weird because it's kind of a side-effect of having a shortName specified, but in turn it makes things a bit easier for when you're hovering over caps.There's ~318 keys in
src/utils/key.tsand 44 of them specify ashortName.