Merged
Conversation
- closed #195 Fix unnecessary mut warnings - closed #194 Fix remaining SLH-DSA warnings - closed #193 Fix remaining unused variables and imports - closed #192 reduce warnings - closed #191 marshal_pkix_public_key auto-detects key type and defaults 32-byte keys to Ed25519, but SLH-DSA-128s also has 32-byte keys. - closed #190 thread 'test_mlkem768_from_private_key_bytes_roundtrip' (10363330) panicked at tests/keys_test.rs:617:5: - closed #189 thread 'test_mlkem1024_from_private_key_bytes_roundtrip' (10363326) panicked at tests/keys_test.rs:659:5: aleft == right failed - closed #188 thread 'test_mldsa44_from_private_key_bytes' (10363314) panicked at tests/keys_test.rs:712:68: - closed #187 Change from OctetString::new() to BitString::from_bytes() - closed #186 Update the post-quantum PKIX marshaling functions to use BitString instead of OctetString - closed #185 PKIX SubjectPublicKeyInfo requires subject_public_key to be a BitString, but the post-quantum marshaling functions use OctetString. - closed #184 PKIX marshaling for post-quantum keys uses OctetString, but PKIX SubjectPublicKeyInfo requires BitString. - closed #183 Investigate the PKIX roundtrip test failures. The error indicates a format mismatch: expected BIT STRING, got OCTET STRING. - closed #182 Fix the import path. - closed #181 Hybrid decryption invalid format - closed #177 Invalid key reconstruction - closed #176 Invalid key sizes - closed #175 Invalid ciphertext sizes for ML-KEM-768 and ML-KEM-1024 - closed #174 test ML-KEM error paths - closed #173 Corrupted signature handling
…ests/pqc_test.rs:40:5: closed #197 - thread test_mlkem1024_key_sizes (10417696) panicked at tests/pqc_test.rs:84:5: closed #198 - thread test_mlkem_automatic_detection (10417702) panicked at tests/pqc_test.rs:96:82: clossed #199 - thread test_pqc_bottle_encryption (10417711) panicked at tests/pqc_test.rs:345:80: closed #200 - thread test_pqc_bottle_encrypted_and_signed (10417710) panicked at tests/pqc_test.rs:388:80:
- closed #200 thread 'test_pqc_bottle_encryption' (10417711) panicked at tests/pqc_test.rs:345:80: - closed #199 thread 'test_mlkem_automatic_detection' (10417702) panicked at tests/pqc_test.rs:96:82: - closed #198 thread 'test_mlkem1024_key_sizes' (10417696) panicked at tests/pqc_test.rs:84:5: - closed #197 thread 'test_mlkem768_key_sizes' (10417699) panicked at tests/pqc_test.rs:40:5: - closed #196 Remove unused imports - closed #195 Fix unnecessary mut warnings - closed #194 Fix remaining SLH-DSA warnings - closed #193 Fix remaining unused variables and imports - closed #191 marshal_pkix_public_key auto-detects key type and defaults 32-byte keys to Ed25519, but SLH-DSA-128s also has 32-byte keys. - closed #190 thread 'test_mlkem768_from_private_key_bytes_roundtrip' (10363330) panicked at tests/keys_test.rs:617:5: - closed #189 thread 'test_mlkem1024_from_private_key_bytes_roundtrip' (10363326) panicked at tests/keys_test.rs:659:5: assertion left == right failed - closed #188 thread 'test_mldsa44_from_private_key_bytes' (10363314) panicked at tests/keys_test.rs:712:68: - closed #187 Change from OctetString::new() to BitString::from_bytes() - closed #186 Update the post-quantum PKIX marshaling functions to use BitString instead of OctetString - closed #185 PKIX SubjectPublicKeyInfo requires subject_public_key to be a BitString, but the post-quantum marshaling functions use OctetString. - closed #184 PKIX marshaling for post-quantum keys uses OctetString, but PKIX SubjectPublicKeyInfo requires BitString. - closed #183 Investigate the PKIX roundtrip test failures. The error indicates a format mismatch: expected BIT STRING, got OCTET STRING. - closed #182 Fix the import path. - closed #181 Hybrid decryption invalid format - closed #177 Invalid key reconstruction - closed #176 Invalid key sizes - closed #175 Invalid ciphertext sizes for ML-KEM-768 and ML-KEM-1024 - closed #174 test ML-KEM error paths
…de feature names (e.g., "ml-kem" instead of "--features ml-kem"), so the command --features ${{ matrix.feature-set }} works correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.