[TH2-4316] Add additional events to the root event with information a…#173
Open
OptimumCode wants to merge 3 commits intodevfrom
Open
[TH2-4316] Add additional events to the root event with information a…#173OptimumCode wants to merge 3 commits intodevfrom
OptimumCode wants to merge 3 commits intodevfrom
Conversation
Contributor
Author
|
@lumber1000 Please, take a look at changes |
Contributor
Author
|
@lumber1000 Please, take a look at changes |
| .bodyData(EventUtils.createMessageBean(message)) | ||
| .bodyData(EventUtils.createMessageBean(ex.message)) | ||
| .bodyData(createMessageBean(message)) | ||
| .bodyData(createMessageBean(ex.message)) |
There was a problem hiding this comment.
Suggested change
| .bodyData(createMessageBean(ex.message)) | |
| .exception(ex, true) |
Comment on lines
+361
to
+380
| name( | ||
| if (lastSequence == DEFAULT_SEQUENCE) { | ||
| "Rule works from the beginning of the cache" | ||
| } else { | ||
| "Rule works from the $lastSequence sequence in session ${sessionKey.sessionAlias} and direction ${sessionKey.direction}" | ||
| } | ||
| ) | ||
| status(PASSED) | ||
| type("ruleStartPoint") | ||
| if (lastSequence != DEFAULT_SEQUENCE) { | ||
| messageID(sessionKey.toMessageID(lastSequence)) | ||
| } | ||
| bodyData(createMessageBean("The rule starts working from " + | ||
| (if (lastSequence == DEFAULT_SEQUENCE) "start of cache" else "sequence $lastSequence") + | ||
| (checkpointTimestamp?.let { | ||
| val instant = checkpointTimestamp.toInstant() | ||
| " and expects messages between $instant and ${instant.plusMillis(taskTimeout.messageTimeout)}" | ||
| } ?: ""))) | ||
| bodyData(createMessageBean("Rule timeout is set to ${taskTimeout.timeout} mls")) | ||
| } |
There was a problem hiding this comment.
Suggested change
| name( | |
| if (lastSequence == DEFAULT_SEQUENCE) { | |
| "Rule works from the beginning of the cache" | |
| } else { | |
| "Rule works from the $lastSequence sequence in session ${sessionKey.sessionAlias} and direction ${sessionKey.direction}" | |
| } | |
| ) | |
| status(PASSED) | |
| type("ruleStartPoint") | |
| if (lastSequence != DEFAULT_SEQUENCE) { | |
| messageID(sessionKey.toMessageID(lastSequence)) | |
| } | |
| bodyData(createMessageBean("The rule starts working from " + | |
| (if (lastSequence == DEFAULT_SEQUENCE) "start of cache" else "sequence $lastSequence") + | |
| (checkpointTimestamp?.let { | |
| val instant = checkpointTimestamp.toInstant() | |
| " and expects messages between $instant and ${instant.plusMillis(taskTimeout.messageTimeout)}" | |
| } ?: ""))) | |
| bodyData(createMessageBean("Rule timeout is set to ${taskTimeout.timeout} mls")) | |
| } | |
| val endOfMessage = checkpointTimestamp?.let { | |
| val instant = checkpointTimestamp.toInstant() | |
| " and expects messages between $instant and ${instant.plusMillis(taskTimeout.messageTimeout)}" | |
| } ?: "" | |
| if (lastSequence == DEFAULT_SEQUENCE) { | |
| name("Rule works from the beginning of the cache") | |
| bodyData(createMessageBean("The rule starts working from start of cache $endOfMessage") | |
| } else { | |
| name("Rule works from the $lastSequence sequence in session ${sessionKey.sessionAlias} and direction ${sessionKey.direction}") | |
| messageID(sessionKey.toMessageID(lastSequence)) | |
| bodyData(createMessageBean("The rule starts working from sequence $lastSequence $endOfMessage") | |
| } | |
| status(PASSED) | |
| type("ruleStartPoint") | |
| bodyData(createMessageBean("Rule timeout is set to ${taskTimeout.timeout} mls")) | |
| } |
| .bodyData(EventUtils.createMessageBean("An unexpected exception has been thrown during result check build")) | ||
| .bodyData(EventUtils.createMessageBean(e.message)) | ||
| .bodyData(createMessageBean("An unexpected exception has been thrown during result check build")) | ||
| .bodyData(createMessageBean(e.message)) |
There was a problem hiding this comment.
Suggested change
| .bodyData(createMessageBean(e.message)) | |
| .exception(e, true) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…bout the cause of failure