[TH2-1686] Use a common executor for running check rules#142
Open
OptimumCode wants to merge 11 commits intodevfrom
Open
[TH2-1686] Use a common executor for running check rules#142OptimumCode wants to merge 11 commits intodevfrom
OptimumCode wants to merge 11 commits intodevfrom
Conversation
cordwelt
previously approved these changes
Apr 29, 2022
OptimumCode
force-pushed
the
th2-1686-op1
branch
2 times, most recently
from
b0c8e32 to
f37450b
Compare
added 5 commits
October 14, 2022 12:21
…bout the cause of failure
OptimumCode
force-pushed
the
th2-1686-op1
branch
from
f37450b to
62277d8
Compare
cordwelt
previously approved these changes
Feb 2, 2023
Comment on lines
+352
to
+357
| bodyData(createMessageBean("The rule starts working from " + | ||
| (if (lastSequence == DEFAULT_SEQUENCE) "start of cache" else "sequence $lastSequence") + | ||
| (checkpointTimestamp?.let { | ||
| val instant = checkpointTimestamp.toInstant() | ||
| " and expects messages between $instant and ${instant.plusMillis(taskTimeout.messageTimeout)}" | ||
| } ?: ""))) |
Contributor
There was a problem hiding this comment.
(if (lastSequence == DEFAULT_SEQUENCE) "start of cache" else "sequence $lastSequence") +
(checkpointTimestamp?.let {
val instant = checkpointTimestamp.toInstant()
" and expects messages between $instant and ${instant.plusMillis(taskTimeout.messageTimeout)}"
} ?: "")
May be build it using buildString instead?
Comment on lines
+531
to
+537
| private fun messageTimeoutText(): String = "Check task was interrupted because the timestamp on the last processed message exceeds the message timeout. " + | ||
| (checkpointTimeout | ||
| ?.toInstant() | ||
| ?.let { | ||
| "Rule expects messages between $it and ${it.plusMillis(taskTimeout.messageTimeout)} " + | ||
| "but processed one outside this range. Check the messages attached to the root rule event to find all processed messages." | ||
| } ?: "But the message timeout is not specified. Contact the developers.") |
!Drop this commit when rebasing on dev branch!
Nikita-Smirnov-Exactpro
approved these changes
Jun 22, 2023
| !task.hasNextRule().also { canBeRemoved -> | ||
| when { | ||
| canBeRemoved -> logger.info("Removed task ${task.description} ($endTime) from tasks map") | ||
| else -> logger.warn("Task ${task.description} can't be removed because it has a continuation") |
There was a problem hiding this comment.
Is this case warn? Maybe use debug log level for logging
| @@ -0,0 +1,26 @@ | |||
| /* | |||
| * Copyright 2022 Exactpro (Exactpro Systems Limited) | |||
There was a problem hiding this comment.
Suggested change
| * Copyright 2022 Exactpro (Exactpro Systems Limited) | |
| * Copyright 2023 Exactpro (Exactpro Systems Limited) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.