Conversation
After reviewing the new policies between cmake 4.2 and 4.3 and testing locally on Arch Linux with cmake 4.3.0 I believe that no user of TGUI would be negatively impacted by using the NEW version of the new policies, so bump the maximum version.
There's no reason to declare/re-open the namespace twice - just fold everything into a single 'namespace tgui'.
It gets included transitively, so the project compiles, but clangd and qtcreator can't work out that it actually gets included eventually and thus show all kinds of errors for various macros, so let's just includew it - it is directly used and doing so makes some tools behave nicer.
They are not used consistently. They increase the file size. They serve no practical purpose. They make the file more cluttered and harder to read.
It doesn't make sense to call the functions and then don't check whether loading succeeded or not or if it does in a few rare cases, then those cases can check the return value or ignore it explicitly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few small commits for you..