changed interface to use instance methods rather than static ones#58
Merged
virajmehta merged 2 commits intomainfrom Jan 20, 2026
Merged
changed interface to use instance methods rather than static ones#58virajmehta merged 2 commits intomainfrom
virajmehta merged 2 commits intomainfrom
Conversation
Aaron1011
approved these changes
Jan 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will allow us to stick parameterized info into tasks so that we can e.g. execute code in a scripting language loaded at runtime.
Note
Modernizes task API to be instance-based and enables dynamic registration.
Tasktrait to use instance methods:name(&self)andrun(&self, ...)Arc<dyn ErasedTask>via newTaskWrapper; worker clones handlers from registryregister<T: Task + Default>()now registers a default instance; addregister_instance<T: Task>; type-safespawn*now requireDefaultand use the instancename()TaskContext::spawn<T>now requiresDefaultand uses instancename(); telemetry field cleanupErasedTaskandTaskWrapper; docs, benches, and tests updated with#[derive(Default)]tasksWritten by Cursor Bugbot for commit d4e9ba6. This will update automatically on new commits. Configure here.