fix(view): add props for width and height to x-icon#1969
fix(view): add props for width and height to x-icon#1969iamdadmin wants to merge 3 commits intotempestphp:3.xfrom
Conversation
|
Weird, I thought that checks were set for manual trigger, I know they are going to fail as it stands as the tests aren't finished, hence leaving it in draft. Sorry, had I known they'd run I wouldn't have raised it as a draft until I had clean tests! |
|
Ready for review, I'd suggest squashing this commit as prettier which wasn't supposed to run on markdown files, ran on markdown files and really messed up the formatting, so there's some regression commits that are over the top. |
brendt
left a comment
There was a problem hiding this comment.
Some thoughts I'd like some input on
944cddf to
744b7f9
Compare
|
Since there was a pile of regression commits due to some formatting errors, I rebased, and re-applied the changes to make this a cleaner commit. Ready for review again, thanks for the feedback! |
|
Can you rebase and resolve the conflicts? Then it's good to merge :) |
|
Awesome, rebased and conflicts resolved :) |
Benchmark ResultsComparison of Open to see the benchmark results
Generated by phpbench against commit 2f49c5c |
Closes #1955
Add props for width and height to x-icon, and ability to disable it entirely so it can be set in style or class
Add prop for style
Update docs
Update tests