Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a tool to check that the world is valid. Run with
temper.exe validateDescription
It primarily checks that the chunks and players are all decodable and match their struct definition, along with decompression checksums for chunks. It does this by iterating all chunks and players stored, then trying to decompress and decode them one by one. Larger worlds will take longer to validate, especially as the number of checks increases. Speaking of which, new checks should be added as new features are added (ie, validating inventories don't contain invalid items, entities don't share UUIDs, etc.)
Motivation and Context
Having a way to check if the world is valid from the command line would be very valuable for automated servers that need to know if the world is invalid as opposed to another type of crash.
How has this been tested?
World format has been changed and checked if the validation fails or not
Screenshots (if appropriate):
Types of changes
Checklist: