Optimize Hangman spacedOut function using set for guessed letters#19
Open
leticialunaz wants to merge 2 commits intotechwithtim:masterfrom
Open
Optimize Hangman spacedOut function using set for guessed letters#19leticialunaz wants to merge 2 commits intotechwithtim:masterfrom
leticialunaz wants to merge 2 commits intotechwithtim:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
Replaced the guessed list with a set() for O(1) lookups and prevention of duplicate letters.
Updated the game loop to only register a guess if it hasn’t been guessed before.
Modified spacedOut to efficiently display letters using the set.
Benefits:
Complexity reduced from O(n*k) to O(n).
Execution time drops significantly in benchmarks, improving overall game performance.
Prevents repeated penalties for the same incorrect guess.