Skip to content

(#151) Add intake roller state machine with dejam mode#153

Open
aidnem wants to merge 3 commits intomainfrom
151-add-intake-dejam
Open

(#151) Add intake roller state machine with dejam mode#153
aidnem wants to merge 3 commits intomainfrom
151-add-intake-dejam

Conversation

@aidnem
Copy link
Copy Markdown
Contributor

@aidnem aidnem commented Mar 24, 2026

Adds a state machine for the rollers which:

  • Tells them to spin when a positive velocity is commanded
  • Tells them to stop when a near-zero velocity is commanded
  • When current is too high and velocity is too low for a certain period of time, aggressively spins them backward for a short period of time to dejam

@aidnem aidnem linked an issue Mar 24, 2026 that may be closed by this pull request
@aidnem
Copy link
Copy Markdown
Contributor Author

aidnem commented Mar 24, 2026

The intake state machine is a little confusing to me, so we need to test this out to make sure I didn't do anything silly.

@aidnem aidnem requested a review from godmar March 24, 2026 16:25
@aidnem aidnem requested a review from godmar March 24, 2026 17:21
Copy link
Copy Markdown
Contributor

@godmar godmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs testing on actual robot

@aidnem
Copy link
Copy Markdown
Contributor Author

aidnem commented Mar 25, 2026

Just to reiterate what I said during shop yesterday, I think we should continue testing the robot and then test and merge this if/when we find another intake jam. Until then, I'm not sure if it's necessary/priority. If we absolutely run out of things to test (e.g. corner shots, indexer, and autos are all looking pretty good) and are just going to do 3 hours of driver practice, then we might want to invest time into tuning this.

@aidnem
Copy link
Copy Markdown
Contributor Author

aidnem commented Mar 25, 2026

I've merged main in here to keep everything up to date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add dejam to intake

2 participants