(#151) Add intake roller state machine with dejam mode#153
Open
(#151) Add intake roller state machine with dejam mode#153
Conversation
Contributor
Author
|
The intake state machine is a little confusing to me, so we need to test this out to make sure I didn't do anything silly. |
godmar
requested changes
Mar 24, 2026
godmar
requested changes
Mar 24, 2026
…ate machine dumps
godmar
approved these changes
Mar 24, 2026
Contributor
godmar
left a comment
There was a problem hiding this comment.
Needs testing on actual robot
Contributor
Author
|
Just to reiterate what I said during shop yesterday, I think we should continue testing the robot and then test and merge this if/when we find another intake jam. Until then, I'm not sure if it's necessary/priority. If we absolutely run out of things to test (e.g. corner shots, indexer, and autos are all looking pretty good) and are just going to do 3 hours of driver practice, then we might want to invest time into tuning this. |
Contributor
Author
|
I've merged main in here to keep everything up to date. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a state machine for the rollers which: