Sync version 105201 by taublast · Pull Request #2 · taublast/ShadersCamera

taublast · 2026-03-08T10:40:41Z

No description provided.

Copilot

Pull request overview

This PR updates the camera app toward release/version 105201, introduces initial UI/VM support for PHOTO vs VIDEO capture behavior, and adjusts platform/project configuration to match the new sync.

Changes:

Add recording-related UI and view model logic (recording badge, shutter behavior, mode concept).
Update app/platform versioning + iOS permission strings.
Switch camera dependency from NuGet to a local project reference and adjust target frameworks / platform build settings.

Reviewed changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 10 comments.

Show a summary per file

File	Description
src/app/Views/MainPageCameraFluent.cs	Adjust capture button busy coloring behavior during recording; update mirroring API usage.
src/app/Views/MainPageCameraFluent.Ui.cs	Add recording badge + shutter UI state changes; (partially) add capture-mode label; disable `OpenHelp()`.
src/app/Views/MainCameraPage.xaml.cs	Remove legacy XAML-based camera page implementation.
src/app/Views/MainCameraPage.xaml	Remove legacy XAML-based camera page layout.
src/app/Views/Controls/CameraWithEffects.cs	Prepare permissions configuration (currently commented).
src/app/ViewModels/CameraViewModel.cs	Introduce capture mode + shutter command that can start/stop video recording; expose recording duration text.
src/app/ShadersCamera.csproj	Change TFMs, add iOS codesigning settings, replace NuGet camera package with external project reference.
src/app/Resources/Strings/ResStrings.resx	Update welcome/help text with shutter + mode switch instructions.
src/app/Platforms/iOS/Info.plist	Bump iOS bundle version and update privacy strings.
src/app/Platforms/iOS/AppDelegate.cs	Add (commented) orientation override and a new UIKit using.
src/app/Platforms/Android/MainActivity.cs	Change Android activity launch mode to `SingleInstance`.
src/app/Platforms/Android/AndroidManifest.xml	Bump Android versionName/versionCode to 1.5/105201.
dev/CameraApp-Refs.sln	Update referenced sample projects in the dev solution.

Comments suppressed due to low confidence (1)

src/app/Views/MainPageCameraFluent.Ui.cs:936

OpenHelp() returns immediately, leaving the popup code unreachable. This effectively disables Help/Welcome flows (including anything calling OpenHelp()), so either remove the early return or gate it behind a debug/feature flag.

        public void OpenHelp()
        {
            return;

            MainThread.BeginInvokeOnMainThread(() =>
            {
                var popup = new HelpPopup();
                this.ShowPopup(popup);
                UserSettings.Save();
            });

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-08T10:45:58Z

src/app/ShadersCamera.csproj

    <!--<TargetFrameworks>net9.0-ios;</TargetFrameworks>-->
-    <!--<TargetFrameworks>net9.0-android;</TargetFrameworks>-->
+    <TargetFrameworks>net9.0-android;</TargetFrameworks>

-    <TargetFrameworks>net9.0-android;net9.0-ios;net9.0-maccatalyst</TargetFrameworks>
-    <TargetFrameworks Condition="$([MSBuild]::IsOSPlatform('windows'))">$(TargetFrameworks);net9.0-windows10.0.19041.0</TargetFrameworks>
+    <!--<TargetFrameworks>net9.0-android;net9.0-ios;net9.0-maccatalyst</TargetFrameworks>
+    <TargetFrameworks Condition="$([MSBuild]::IsOSPlatform('windows'))">$(TargetFrameworks);net9.0-windows10.0.19041.0</TargetFrameworks>-->


The project is now pinned to net9.0-android only, with iOS/macCatalyst/Windows target frameworks commented out. If this PR is only meant to sync app versioning, this is a breaking build/config change; consider restoring the multi-target list (or documenting why other TFMs are intentionally disabled).

Copilot · 2026-03-08T10:45:59Z

src/app/Platforms/iOS/AppDelegate.cs

@@ -1,10 +1,19 @@
 using Foundation;
+using UIKit;


using UIKit; is currently only needed for code that is commented out, so it will be an unused using directive. Either remove the using or re-enable the orientation override (if it’s required).

Suggested change

using UIKit;

Copilot · 2026-03-08T10:45:59Z

src/app/ViewModels/CameraViewModel.cs

+        try
        {
-            if (Camera != null)
+            if (Camera.IsRecording)
            {
-                Camera.CaptureSuccess -= OnCaptureSuccess;
-                Camera.StateChanged -= OnCameraStateChanged;
-                Camera.NewPreviewSet -= OnNewPreviewSet;
-                Camera = null;
+                await Camera.StopVideoRecording().ConfigureAwait(false);
            }
+            else
+            {
+                RecordingDuration = TimeSpan.Zero;
+                await Camera.StartVideoRecording().ConfigureAwait(false);
+            }
+        }
+        catch
+        {
+            // Caller can add user-facing error handling later.
+        }


CommandShutterTapped swallows all exceptions with an empty catch, which makes failures (permissions, unsupported recording, IO errors) silent and very hard to diagnose. At minimum log the exception (and/or surface a user-facing error) and consider restoring state (e.g., resetting Mode/RecordingDuration) if start/stop fails.

Copilot · 2026-03-08T10:45:59Z

src/app/ShadersCamera.csproj

+  <PropertyGroup Condition="$(TargetFramework.Contains('ios'))">
+    <ProvisioningType>manual</ProvisioningType>
+    <CodesignKey>Apple Distribution: NIKOLAY KOVALSKIY (F5H2D34D9G)</CodesignKey>
+    <CodesignProvision>ShadersCam AppStore</CodesignProvision>
+  </PropertyGroup>


The iOS codesigning settings (CodesignKey / CodesignProvision) are hard-coded in the project file. This is machine/account-specific and can break builds for other developers/CI; move these to a user-specific/CI-only import (e.g., Directory.Build.props, *.targets excluded from source, or build pipeline variables) instead of committing distribution identity details to the repo.

Copilot · 2026-03-08T10:46:00Z

src/app/ShadersCamera.csproj



+  <ItemGroup>
+    <ProjectReference Include="..\..\..\DrawnUi.Maui\src\Maui\Addons\DrawnUi.Maui.Camera\DrawnUi.Maui.Camera.csproj" />


DrawnUi.Maui.Camera NuGet reference is commented out and replaced with a ProjectReference pointing outside this repository (..\..\..\DrawnUi.Maui\...). This will fail for anyone who doesn’t have that sibling path (and in most CI checkouts). Prefer keeping the PackageReference, or ensure the referenced project is included via submodule / repository layout that CI can resolve.

Suggested change

<ProjectReference Include="..\..\..\DrawnUi.Maui\src\Maui\Addons\DrawnUi.Maui.Camera\DrawnUi.Maui.Camera.csproj" />

<PackageReference Include="DrawnUi.Maui.Camera" Version="1.0.0" />

Copilot · 2026-03-08T10:46:00Z

src/app/Platforms/iOS/Info.plist

 	<key>CFBundleVersion</key>
-	<string>141002</string>
+	<string>151004</string>


CFBundleVersion (151004) doesn’t match the PR title/version sync target (105201) and also diverges from Android versionCode (105201). If the intent is to keep build numbers aligned across platforms, update iOS to the same scheme or clarify the versioning policy.

Copilot · 2026-03-08T10:46:00Z

src/app/Platforms/Android/MainActivity.cs

 {
    [Activity(Theme = "@style/MainTheme", MainLauncher = true,
-        LaunchMode = LaunchMode.SingleTask,
+        LaunchMode = LaunchMode.SingleInstance,


Changing the main activity to LaunchMode.SingleInstance materially alters Android task/back-stack and intent delivery semantics (activity runs in its own task, no other activities can join it). If the goal is just to avoid duplicate instances, SingleTask is usually sufficient; otherwise please document why SingleInstance is required and verify share/deep-link flows still work.

Suggested change

LaunchMode = LaunchMode.SingleInstance,

LaunchMode = LaunchMode.SingleTask,

Copilot · 2026-03-08T10:46:00Z

src/app/Views/MainPageCameraFluent.Ui.cs

                VerticalOptions = LayoutOptions.Fill,
                Children =
                {
+                    //CreateCaptureModeLabel(), //todo in next version for video


CreateCaptureModeLabel() is commented out, so there is currently no UI affordance to switch between PHOTO/VIDEO modes even though the view model and help text imply this feature exists. Either enable this control (or provide another toggle) or remove/disable the mode-switching/help text until it’s wired up.

Suggested change

//CreateCaptureModeLabel(), //todo in next version for video

CreateCaptureModeLabel(),

Copilot · 2026-03-08T10:46:01Z

src/app/Resources/Strings/ResStrings.resx

 - Choose your filter from bottom drawer menu!
 - Can zoom camera with fingers
+- Tap shutter to take a photo
+- Tap PHOTO/VIDEO label to switch mode


WelcomeDetails instructs users to tap a PHOTO/VIDEO label to switch modes, but the current Fluent UI has the capture-mode label creation commented out, so this instruction is inaccurate. Either wire up and show the mode label, or update the welcome text to match the current UI.

Suggested change

- Tap PHOTO/VIDEO label to switch mode

Copilot · 2026-03-08T10:46:01Z

src/app/ViewModels/CameraViewModel.cs

+    private CaptureUIMode _mode;
+    private TimeSpan _recordingDuration;
+
+    private readonly SemaphoreSlim semaphoreProcessingFrame = new(1, 1);


semaphoreProcessingFrame is declared but never used, which is dead code now that preview-frame processing was removed. Remove it (or reintroduce the logic that needs it) to avoid confusion and unnecessary allocations.

Suggested change

private readonly SemaphoreSlim semaphoreProcessingFrame = new(1, 1);

taublast added 7 commits February 19, 2026 13:07

droid published, crashing on ios

1cffc81

Update CameraApp-Refs.sln

1a42f5a

try mic permission

1342ddd

Update Info.plist

c42b7fa

fix mic crash

f8c2aea

restore effect

0bf4407

sync pub

76bb6ef

Copilot AI review requested due to automatic review settings March 8, 2026 10:40

taublast merged commit 6a4f237 into main Mar 8, 2026
2 of 3 checks passed

Copilot started reviewing on behalf of taublast March 8, 2026 10:41 View session

Copilot AI reviewed Mar 8, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sync version 105201#2

Sync version 105201#2
taublast merged 7 commits intomainfrom
dev

taublast commented Mar 8, 2026

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 8, 2026

Uh oh!

Copilot AI Mar 8, 2026

Uh oh!

Copilot AI Mar 8, 2026

Uh oh!

Copilot AI Mar 8, 2026

Uh oh!

Copilot AI Mar 8, 2026

Uh oh!

Copilot AI Mar 8, 2026

Uh oh!

Copilot AI Mar 8, 2026

Uh oh!

Copilot AI Mar 8, 2026

Uh oh!

Copilot AI Mar 8, 2026

Uh oh!

Copilot AI Mar 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants



		<ItemGroup>
		<ProjectReference Include="..\..\..\DrawnUi.Maui\src\Maui\Addons\DrawnUi.Maui.Camera\DrawnUi.Maui.Camera.csproj" />

	<ProjectReference Include="..\..\..\DrawnUi.Maui\src\Maui\Addons\DrawnUi.Maui.Camera\DrawnUi.Maui.Camera.csproj" />
	<PackageReference Include="DrawnUi.Maui.Camera" Version="1.0.0" />

	LaunchMode = LaunchMode.SingleInstance,
	LaunchMode = LaunchMode.SingleTask,

	//CreateCaptureModeLabel(), //todo in next version for video
	CreateCaptureModeLabel(),

Conversation

taublast commented Mar 8, 2026

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Mar 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 8, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants