Conversation
topics/tags.md
Outdated
| | ----------- | -------------- | ------------------------- | -------------------------------------- | | ||
| | `tag_guid` | `VARCHAR(64)` | The guid of the tag | `478A70D8-C627-91EC-D681-FFE617FABDD9` | | ||
| | `title` | `VARCHAR(max)` | The tag title | `Open access` | | ||
| | `is_active` | `boolean` | Enables or disables a tag | `0` or `1` | |
There was a problem hiding this comment.
Comment: I think 0 and 1 are the correct values here?
There was a problem hiding this comment.
[question] Where did you get those values from? See here the values returned when querying are string values.
There was a problem hiding this comment.
Where did you get those values from?
A guess. Looking further into it I see there are multiple values that are acceptable based on the redshift docs on the Boolean type
| State | Valid literal values | Storage |
|---|---|---|
| True | TRUE 't' 'true' 'y' 'yes' '1' | 1 byte |
| False | FALSE 'f' 'false' 'n' 'no' '0' | 1 byte |
| Unknown | NULL | 1 byte |
There was a problem hiding this comment.
I'm going to make it true/false
There was a problem hiding this comment.
Pull request overview
Adds documentation for the new f_rl_tags table and exposes it in the site navigation, along with a small ERD update to include the table in the relationships diagram.
Changes:
- Add a new topic page documenting
public.f_rl_tagsand its columns. - Add “Tags” to the Application data navigation.
- Extend the Mermaid ER diagram to include
f_rl_tags.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
topics/tags.md |
New data dictionary page for the f_rl_tags table (columns + definitions). |
topics/entity-relationships.md |
Adds f_rl_tags entity to the Mermaid ER diagram. |
_includes/nav.html |
Adds a nav entry linking to the new Tags topic page. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
topics/tags.md
Outdated
| | Column Name | Datatype | Description | Example | | ||
| | ----------- | -------------- | ------------------------- | -------------------------------------- | | ||
| | `tag_guid` | `VARCHAR(64)` | The guid of the tag | `478A70D8-C627-91EC-D681-FFE617FABDD9` | | ||
| | `title` | `VARCHAR(max)` | The tag title | `Open access` | |
There was a problem hiding this comment.
VARCHAR(max) isn’t used anywhere else in the data dictionary and isn’t a valid type in Postgres/Redshift-style dialects (this repo consistently uses sized VARCHAR(n) like VARCHAR(255) / VARCHAR(4096)). Please align the title datatype with the actual column type and existing docs conventions (e.g. a sized VARCHAR(n) or TEXT as appropriate).
| | `title` | `VARCHAR(max)` | The tag title | `Open access` | | |
| | `title` | `VARCHAR(255)` | The tag title | `Open access` | |
There was a problem hiding this comment.
Anyone else have thoughts on this. I based it on the value used in the PR to add the tags table:
s_rl_tags_: {
columns: {
tag_guid: 'varchar(64)',
title: 'varchar(max)',
is_active: 'boolean',There was a problem hiding this comment.
I've added a comment to that PR: https://github.com/talis/census-server/pull/514/changes#r2994065803
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Summary
TA-3538
Update documentation with new tags table
Changes
tag_guidtitleis_active