cmd/go/internal/test: add opt-in file hashing instead of modtime for test caching (w/ git)#152
Closed
bradfitz wants to merge 0 commit intotailscale.go1.25from
Closed
cmd/go/internal/test: add opt-in file hashing instead of modtime for test caching (w/ git)#152bradfitz wants to merge 0 commit intotailscale.go1.25from
bradfitz wants to merge 0 commit intotailscale.go1.25from
Conversation
Member
Author
|
Newer version of #151. I'll squash this into the other commit when merging, force pushing. |
bradfitz
force-pushed
the
bradfitz/25_githash
branch
from
59e0091 to
7199694
Compare
bradfitz
force-pushed
the
bradfitz/25_githash
branch
from
7199694 to
485c689
Compare
tomhjp
approved these changes
Jan 28, 2026
Member
tomhjp
left a comment
tomhjp
left a comment
There was a problem hiding this comment.
Thanks! LGTM, just missing some docs on a couple exported symbols, although it is an internal package
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates golang#58571
Updates #150