Set Unicorn environment according to RACK_ENV#56
Open
Tensho wants to merge 1 commit intotablexi:masterfrom
Open
Set Unicorn environment according to RACK_ENV#56Tensho wants to merge 1 commit intotablexi:masterfrom
Tensho wants to merge 1 commit intotablexi:masterfrom
Conversation
Author
|
@ahorner, Please, could you give any idea, does it make sense? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are plenty of non-Rails applications (Grape, Sinatra, etc.) that could be served with Unicorn help. It seems to me relying on RACK_ENV as the more general sign may help in such a case. Also, I don't understand the purpose of "deployment" default option. I mean I understand, that it corrects default rack stack to use the only Rack::CommonLogger middleware, but I have never seen such setup in live. Usually people run staging or production envs within deployment.