Open
Conversation
5b58a90 to
dca576e
Compare
There was a problem hiding this comment.
Pull request overview
Adds a new UDP splitting trait to support dynamic IPv4/IPv6 multicast join/leave operations after a socket has been split into independent halves (for group messaging scenarios such as Matter Groups).
Changes:
- Introduces
UdpSplitMulticastand updatesUdpConnect::Socketto require it. - Implements
UdpSplitMulticastforedge-nal-std::UdpSocketandedge-nal-embassy::UdpSocket, including multicast impls for&UdpSocket(embassy). - Minor refactors/simplifications in mDNS broadcast iterator construction and HTTP server/task logic.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| edge-nal/src/stack/udp.rs | Adds UdpSplitMulticast and tightens UdpConnect::Socket bounds to require it. |
| edge-nal-std/src/lib.rs | Implements UdpSplitMulticast for the std UDP socket wrapper. |
| edge-nal-embassy/src/udp.rs | Implements UdpSplitMulticast for embassy UDP socket and adds multicast traits for &UdpSocket. |
| edge-mdns/src/io.rs | Simplifies IPv6 broadcast iterator chaining. |
| edge-http/src/lib.rs | Refactors chunked/HTTP1.0 validation into a guarded match arm. |
| edge-http/src/io/server.rs | Refactors acceptor loop to iterate signals instead of indexing. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dca576e to
2c9b853
Compare
2c9b853 to
a36e56b
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that
rs-matterhad gained Groups support, we do need a way to join/leave Ipv6 multicast groups on a split-socket.While for mDNS this was not necessary, as the socket can join the mDNS multicast group before it is split, the
rs-mattergroups' functionality demands dynamic multicast group join/leave while the socket is already split into a read + write halves and operating as such.So in a way we need a new type of socket split that either:
UdpSendbut alsoMulticastV4andMulticastV6This PR implements the second approach, though for rs-matter specifically the first approach would work too.