Fix testEnvCanBeReferenced for dotenv deferred resolution#1084
Open
GromNaN wants to merge 1 commit intosymfony:2.xfrom
Open
Fix testEnvCanBeReferenced for dotenv deferred resolution#1084GromNaN wants to merge 1 commit intosymfony:2.xfrom
GromNaN wants to merge 1 commit intosymfony:2.xfrom
Conversation
GromNaN
changed the title
…ution symfony/dotenv >= 6.4.35/7.4.7/8.0.7 defers variable resolution so BAR=$FOO now resolves using the .env value of FOO rather than the system env at dump time.
GromNaN
force-pushed
the
fix-dump-env-test-deferred-dotenv-resolution
branch
from
3e8a659 to
2d94786
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
symfony/dotenv>= 6.4.35/7.4.7/8.0.7 introduced deferred variable resolution (symfony/symfony#63496): variables likeBAR=$FOOare now resolved after all.envfiles are loaded, using$_ENV['FOO'](set bypopulate()from.env) rather than the system env at dump time.This caused
testEnvCanBeReferencedto fail:BARnow resolves to'123'(from.env) instead of'Foo'(from$_SERVERvia the runtime PHP expression).The test is updated to use
InstalledVersions::satisfies()to assert the correct expected value depending on the installed dotenv version, keeping compatibility with both old and new behavior.