Fix "null as array offset" deprecation in DockerComposeConfigurator#1083
Open
GromNaN wants to merge 1 commit intosymfony:2.xfrom
Open
Fix "null as array offset" deprecation in DockerComposeConfigurator#1083GromNaN wants to merge 1 commit intosymfony:2.xfrom
GromNaN wants to merge 1 commit intosymfony:2.xfrom
Conversation
Since 33ce7c1, new compose.yaml files are created empty instead of being seeded with "version: '3'\n". When the file is empty, the parsing loop finds no top-level keys and $node stays null, causing "Using null as an array offset" deprecations when $endAt[$node] is written. Guard both assignments with `null !== $node` checks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1079
Summary
PHP 8.5 introduces a deprecation notice when
nullis used as an array offset:In
configureDockerCompose(),$nodeis initialized tonulland used as an array key in$endAt[$node]before being assigned — once at the first top-level key encounter during the parsing loop, and once after the loop when the file is empty (e.g. a freshly createdcompose.yaml).Fix
Guard both
$endAt[$node]assignments withnull !== $nodechecks, since there is no previous section to record an end position for.