feat: Pagination. Add Page class and req params mapper#101
Open
OlegMakarenko wants to merge 2 commits intodevfrom
Open
feat: Pagination. Add Page class and req params mapper#101OlegMakarenko wants to merge 2 commits intodevfrom
OlegMakarenko wants to merge 2 commits intodevfrom
Conversation
AnthonyLaw
reviewed
Nov 12, 2021
| return all; | ||
| }, []); | ||
|
|
||
| export const reqToPageParameters = (req: Request, filterKeys?: Array<string>): { [key: string]: unknown } => { |
Member
There was a problem hiding this comment.
Array<string> vs string[]
I think we have different styles for the Typescript type, should we unite the style?
AnthonyLaw
reviewed
Nov 12, 2021
Member
AnthonyLaw
left a comment
There was a problem hiding this comment.
Look good for me.
@fboucquez @yilmazbahadir has a better experience than me as they are working pagination for SDK and REST.
fc6c3a7 to
e756bdc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Usage: