[wallet/desktop] support revokable mosaic creation#2016
Open
inatatsu-tatsuhiro wants to merge 2 commits intosymbol:devfrom
Open
[wallet/desktop] support revokable mosaic creation#2016inatatsu-tatsuhiro wants to merge 2 commits intosymbol:devfrom
inatatsu-tatsuhiro wants to merge 2 commits intosymbol:devfrom
Conversation
inatatsu-tatsuhiro
changed the title
Author
|
The description of revokable in mosaic creation is only available in Japanese. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #2016 +/- ##
==========================================
- Coverage 53.75% 53.73% -0.02%
==========================================
Files 585 585
Lines 14018 14020 +2
Branches 2351 2351
==========================================
- Hits 7535 7534 -1
- Misses 6433 6436 +3
Partials 50 50
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
AnthonyLaw
reviewed
Sep 8, 2025
| "flags_divisibility": "Determines the number of decimal places to which the mosaic can be divided. The divisibility must be between 0 and 6 (included).", | ||
| "flags_duration_permanent": "If set to true, the mosaic will never expire.", | ||
| "flags_restrictable": "If set to true, the mosaic owner can configure custom restrictions.", | ||
| "flags_revokable": "If set to true...", |
Member
There was a problem hiding this comment.
Suggested change
| "flags_revokable": "If set to true...", | |
| "flags_revokable": "If set to true, the mosaic owner can revoke (cancel) the transfer of mosaics.", |
AnthonyLaw
reviewed
Sep 8, 2025
| "flags_divisibility": "모자이크의 소수점 자리를 지정할 수 있는 값입니다. 가분성은 0에서 6 사이의 정수만 가능합니다.", | ||
| "flags_duration_permanent": "만약 값을 true로 설정한다면, 만료일 없이 생성 가능합니다.", | ||
| "flags_restrictable": "만약 값을 true로 설정한다면, 모자이크 주인이 제한설정을 변경할 수 있게 됩니다.", | ||
| "flags_revokable": "만약 값을 true로 설정한다면...", |
Member
There was a problem hiding this comment.
Suggested change
| "flags_revokable": "만약 값을 true로 설정한다면...", | |
| "flags_revokable": "True인 경우, 모자이크 소유자는 모자이크 전송을 취소할 수 있습니다.", |
AnthonyLaw
reviewed
Sep 8, 2025
| "resolving_address": "Разрешение адреса {address}...", | ||
| "restore_mnemonic": "Восстановить мнемоническую парольную фразу", | ||
| "restrictable": "Ограничения", | ||
| "revokable": "отмене", |
Member
There was a problem hiding this comment.
Suggested change
| "revokable": "отмене", | |
| "revokable": "Подлежит отмене", |
AnthonyLaw
reviewed
Sep 8, 2025
| "flags_divisibility": "Определяет количество десятичных знаков, на которое можно разделить мозаику. Делимость должна быть от 0 до 6 (включительно).", | ||
| "flags_duration_permanent": "Если установлено значение (true), мозаика никогда не истечет.", | ||
| "flags_restrictable": "Если установлено значение (true), владелец мозаики может настраивать пользовательские ограничения.", | ||
| "flags_revokable": "Если установлено значение (true)...", |
Member
There was a problem hiding this comment.
Suggested change
| "flags_revokable": "Если установлено значение (true)...", | |
| "flags_revokable": "Если значение установлено в true, владелец мозаики может отозвать (отменить) её передачу.", |
AnthonyLaw
reviewed
Sep 8, 2025
| "flags_divisibility": "确定可以分割马赛克的小数点位置。可分割性必须在0和6之间", | ||
| "flags_duration_permanent": "如果选择，马赛克将永远不会过期", | ||
| "flags_restrictable": "如果选择，马赛克创建者可以配置自定义限制", | ||
| "flags_revokable": "如果选择...", |
Member
There was a problem hiding this comment.
Suggested change
| "flags_revokable": "如果选择...", | |
| "flags_revokable": "如果选择，赛克拥有者可以撤销马赛克的转移", |
Member
|
Great work! Please add a unit test for that. the file should located here: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for the revokable flag when creating mosaics, allowing users to specify whether a mosaic can be revoked after issuance.
Changes
Implementation Details
FormMosaicDefinitionTransactionto include the revokable fieldMosaicFlags.create()call to pass the revokable parameter as the 4th argumenttable_header_revokableandflags_revokabletranslation keysViewMosaicDefinitionTransactionto display revokable statusMosaicTableServiceto include revokable columnTesting
Screenshots
[Add screenshots of the revokable checkbox and table display]
Checklist
Closes #2015