Skip to content

Move the similar function merging pass into the LLVM repo#20451

Closed
vedantk wants to merge 3 commits intoswiftlang:masterfrom
vedantk:move-merge-funcs
Closed

Move the similar function merging pass into the LLVM repo#20451
vedantk wants to merge 3 commits intoswiftlang:masterfrom
vedantk:move-merge-funcs

Conversation

@vedantk
Copy link
Copy Markdown
Contributor

@vedantk vedantk commented Nov 9, 2018

This makes it easier to experiment with function merging in clang.

This set of PRs just does pure code movement.

Depends on:
apple/swift-llvm#123
apple/swift-clang#231

rdar://45707083

@vedantk
Copy link
Copy Markdown
Contributor Author

vedantk commented Nov 9, 2018

apple/swift-llvm#123
apple/swift-clang#231
@swift-ci please smoke test

@aschwaighofer
Copy link
Copy Markdown
Contributor

LGTM

Copy link
Copy Markdown
Contributor

@eeckstein eeckstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

This fixes a link error in swift-llvm-opt.
@vedantk
Copy link
Copy Markdown
Contributor Author

vedantk commented Nov 9, 2018

apple/swift-llvm#123
apple/swift-clang#231
@swift-ci please smoke test

@vedantk
Copy link
Copy Markdown
Contributor Author

vedantk commented Nov 9, 2018

apple/swift-llvm#123
apple/swift-clang#231
@swift-ci please smoke test

@vedantk
Copy link
Copy Markdown
Contributor Author

vedantk commented Nov 9, 2018

@eeckstein @aschwaighofer thanks for the reviews!

Here's my plan for landing this:

  1. Commit the llvm & clang parts to github/upstream-with-swift, then cherry-pick to swift-5.0-branch.
  2. Wait until the changes are auto-merged into the swift-{llvm,clang}/stable branches. This can't be forced -- those branches are gated.
  3. Merge this PR to delete swift's copy of the pass.

Does that sound right?

@vedantk
Copy link
Copy Markdown
Contributor Author

vedantk commented Nov 9, 2018

On second thought, it might be more difficult to maintain a copy of this pass in the upstream-with-swift branch, as it would require more effort to keep it in sync with llvm.org. Let's wait until we can really upstream this pass to do this.

@vedantk vedantk closed this Nov 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants