jextract: Use fully qualified java.lang.String to avoid shadowing#696
Merged
ktoso merged 2 commits intoswiftlang:mainfrom Apr 10, 2026
Merged
jextract: Use fully qualified java.lang.String to avoid shadowing#696ktoso merged 2 commits intoswiftlang:mainfrom
java.lang.String to avoid shadowing#696ktoso merged 2 commits intoswiftlang:mainfrom
Conversation
Collaborator
|
Lgtm! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When generating Java code for next Swift type a nested Java record named
Stringis created.This causes the standard
java.lang.Stringto be shadowed within that scope, leading to uncompilable source code where the generator expects the standard JDKStringbut finds the newly generated one instead.To prevent this, the generator now uses the fully qualified name.
Note
This applies to other types as well (such as
AtomicBoolean), but I am only addressing String in this PR for now.