Skip to content

Small refactorings and cleanups#692

Merged
ktoso merged 7 commits intoswiftlang:mainfrom
sidepelican:small_cleanup
Apr 9, 2026
Merged

Small refactorings and cleanups#692
ktoso merged 7 commits intoswiftlang:mainfrom
sidepelican:small_cleanup

Conversation

@sidepelican
Copy link
Copy Markdown
Contributor

@sidepelican sidepelican commented Apr 9, 2026

Fix several minor issues encountered during development.

  • Fix unused variable warnings.
  • Replaced force-unwraps (!) in tests to #require.
  • Removed #if hasFeature(ImplicitOpenExistentials) since the project now targets Swift 6.1 and later.
  • Updated config.writeEmptyFiles to provide its default value using the same pattern as other configuration properties.

@sidepelican sidepelican requested a review from ktoso as a code owner April 9, 2026 07:00
Copy link
Copy Markdown
Collaborator

@ktoso ktoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanups thanks

@sidepelican
Copy link
Copy Markdown
Contributor Author

hasFeature(ImplicitOpenExistentials) was dependent on -swift-version 6 🙃

@ktoso
Copy link
Copy Markdown
Collaborator

ktoso commented Apr 9, 2026

Hah, I was tempted on removing that one a while back

@ktoso ktoso merged commit dd38340 into swiftlang:main Apr 9, 2026
64 checks passed
@sidepelican sidepelican deleted the small_cleanup branch April 10, 2026 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants