Windows: add smoke test Dockerfiles with full Windows#533
Open
speednoisemovement wants to merge 2 commits intoswiftlang:mainfrom
Open
Windows: add smoke test Dockerfiles with full Windows#533speednoisemovement wants to merge 2 commits intoswiftlang:mainfrom
speednoisemovement wants to merge 2 commits intoswiftlang:mainfrom
Conversation
The current Dockerfiles use Microsoft's `servercore` base images. These are cut down enough that they will not run many real Windows Swift applications: for example, `swift-win32` fails because the DLL responsible for app lifecycle notifications, `win-core-psm-appnotify-l1-1-0.dll`, is missing on `servercore:1809`. This introduces new Dockerfiles based on `windows:1809` and `windows/server:ltsc2022` which provide a better test environment. Other than base images, the only difference between these and the existing `servercore`-based images is the addition of `-ExecutionPolicy Bypass` since the full images default to `Restricted` and this is incompatible with running a PowerShell script as the entry point.
compnerd
approved these changes
Mar 12, 2026
Contributor
Author
|
@justice-adams-apple @shahmishal does this seem OK? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current Dockerfiles use Microsoft's
servercorebase images. These are cut down enough that they will not run many real Windows Swift applications: for example,swift-win32fails because the DLL responsible for app lifecycle notifications,win-core-psm-appnotify-l1-1-0.dll, is missing onservercore:1809.This introduces new Dockerfiles based on
windows:1809andwindows/server:ltsc2022which provide a better test environment.Other than base images, the only difference between these and the existing
servercore-based images is the addition of-ExecutionPolicy Bypasssince the full images default toRestrictedand this is incompatible with running a PowerShell script as the entry point.