Code review pass 2: security hardening, UX fixes, and documentation u…#53
Merged
Code review pass 2: security hardening, UX fixes, and documentation u…#53
Conversation
…pdates Security: - Reject unverified CRLs when issuer cert is unavailable (crl.rs) - Add SHA-1 signature algorithm check to WebPKI weak crypto validation - Add ECDSA_WITH_SHA1 and DSA_WITH_SHA1 OID constants UX improvements: - Field/Show directory batch modes now exit non-zero on failures - Stdin input rejects data exceeding 10 MiB limit instead of silent truncation Code quality: - Add clarifying comments to parser.rs (serial formatting, X.509 version encoding, RSA DER integer encoding) Documentation: - Update test counts from 276 to 279 (3 doc-tests added in previous pass) All 279 tests pass, 0 clippy warnings, clean formatting. https://claude.ai/code/session_015DHAwWcCFpG7vHAECwFucN
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…pdates
Security:
UX improvements:
Code quality:
Documentation:
All 279 tests pass, 0 clippy warnings, clean formatting.
https://claude.ai/code/session_015DHAwWcCFpG7vHAECwFucN