Add curve, dns-names, and ip-addrs fields; improve documentation#51
Merged
Add curve, dns-names, and ip-addrs fields; improve documentation#51
Conversation
New features: - Add `curve` field to extract EC named curve (P-256, P-384, P-521) - Add `dns-names` field to extract DNS names from SAN extension - Add `ip-addrs` field to extract IP addresses from SAN extension Documentation fixes: - Expand field list in README into a table with descriptions - Clarify that `emails` extracts from both subject DN and SAN extension - Document all check types (host, email, ip) with their accepted values - Document all verify options including --hostname, --CAfile, --CApath, --untrusted, --CRLfile, --crl-check, --crl-check-all - Document bulk JSON summary fields and clarify that succeeded/failed count processing outcomes, not check results - Fix CRL flag name in Features section (--CRLfile not --crl-file) Breaking change: - Rename bulk JSON summary field `passed` to `succeeded` to accurately reflect semantics across all subcommands (show, field, check, verify) https://claude.ai/code/session_01MV6PaFHhxHFhjMiaU7zDF8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds three new certificate field extraction commands (
curve,dns-names,ip-addrs) and significantly improves the README documentation with structured tables for available fields, check types, and verify options.Key Changes
New Features
curvefield: Extract EC curve names (e.g., P-256, P-384, P-521) from EC certificatesdns-namesfield: Extract DNS names directly from the SAN extensionip-addrsfield: Extract IP addresses (IPv4 and IPv6) directly from the SAN extensionxcert-lib/src/fields.rs:CertificateInfo::curve()- returns EC curve nameCertificateInfo::dns_names()- filters SAN entries for DNS namesCertificateInfo::ip_addresses()- filters SAN entries for IP addressesDocumentation Improvements
expiry,host,email, andipchecks with their value formatss,m/min,h/hr,d/day,w/week,month,y/year)succeededvsfailedcountspassedtosucceededin JSON batch summary to better reflect actual semantics--crl-file→--CRLfileImplementation Details
Curve,DnsNames, andIpAddrsvariants to theFieldNameenumJSON Output Changes
passedtosucceededin batch operation summaries to clarify that it counts files processed without errors, not checks that passedcheckandverifycommands, individual pass/fail status is in per-resultdata, not in the summaryhttps://claude.ai/code/session_01MV6PaFHhxHFhjMiaU7zDF8