Open
Conversation
SilasPeters
requested changes
Nov 16, 2025
Member
SilasPeters
left a comment
There was a problem hiding this comment.
I see this review has never been submitted, whoops. DOn't know if it is outdated, but I need to do other thigns now.
13eaf27 to
3956ebf
Compare
SilasPeters
approved these changes
Dec 31, 2025
Member
|
Don't merge just yet |
SilasPeters
requested changes
Dec 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR upgrades our servers to Ubuntu 24.04.03 LTS. Below is a list of the
changes made, since it affects quite a few files.
README
The README is out-of-date in several places. I updated it in the places that were
relevant to this PR, but we should update the entire thing. I created #521 to address this.
ansible/deploy.pyMade it so that when you do not pass
--roles,--fromor--untilit sendsthe string "All" to discord instead of the empty string.
Role
vars/Ubuntu 24 has some subtle changes to the way user home creations are handled.
No roles make a user home, they explicitly add it. If this is not done, nginx
does not have the correct permissions to access websites' files, making it so
that websites do not work entirely.
Put user homes in variables to avoid hardcoding.
The following roles are affected by this:
AWS Console
On Ubuntu 24.04, the apt package
awsclidoes not exist anymore. It has beenmoved to snap. There were also some roles that used
awsclibut depended onother roles installing it. They now explicitly install it.
Pretix
Python versions have been updated to 3.12. Silas and I think we should look
into moving pretix to uv for consistency with other projects.
The role previously depended on the
venvalready existing, added a check tosee if it does.
Ubuntu 24 no longer has
awscliin apt. It has been moved to snap. Some rolesdepended on other roles installing it. They now explicitly install it.