Skip to content

fix: avoid false-positive overridden base warning when setting paths.base#15623

Merged
teemingc merged 5 commits intomainfrom
fix-overridden-warning
Apr 1, 2026
Merged

fix: avoid false-positive overridden base warning when setting paths.base#15623
teemingc merged 5 commits intomainfrom
fix-overridden-warning

Conversation

@teemingc
Copy link
Copy Markdown
Member

@teemingc teemingc commented Mar 31, 2026

closes #15361

This PR changes the config hooks we have to run with order: 'pre' so that they don't override the base setting set by Vitest. If we run our config hooks earlier, Vitest doesn't try to set the base setting where we already have


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 31, 2026

🦋 Changeset detected

Latest commit: 5154d66

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@svelte-docs-bot
Copy link
Copy Markdown

@teemingc
Copy link
Copy Markdown
Member Author

teemingc commented Apr 1, 2026

/autofix

@teemingc teemingc merged commit 56c921d into main Apr 1, 2026
7 checks passed
@teemingc teemingc deleted the fix-overridden-warning branch April 1, 2026 06:34
This was referenced Apr 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Overridden config warning when using Vitest 4 and paths.base in svelte.config.js

2 participants