Open
Conversation
gonuke
requested changes
Mar 4, 2026
Member
gonuke
left a comment
gonuke
left a comment
There was a problem hiding this comment.
Looking for some consistency in return quantities across the set of functions are are developing...
| all_sched_t_irr += sched_t_irr | ||
| all_sched_abt += sched_active_burn_time | ||
| tot_ff = all_sched_abt / all_sched_t_irr | ||
| return all_sched_t_irr, tot_ff |
Member
There was a problem hiding this comment.
Noting that you changed which quantities are being returned by the previous function... I think it makes sense to have all these function return a consistent pair of values, any two of:
- total irradiation time
- total burn time
- flux factor
Since the third can always be inferred from any other two, it makes sense to allow users to have an assumption about which two it will be by being consistent across the various functions.
Contributor
Author
There was a problem hiding this comment.
Changed flatten_simple_sched() to have it return irradiation time and flux factor as before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds upon #78 to extend the flattening approximation to multiple simple schedules.
fixes #23