Conversation
…exports (fetchWithCache, cacheHandler, createCacheHandler) - Verify type exports and backend utilities - Test instrumentation utilities exports - Improves coverage for src/index.ts to 100%
…DefaultBackend function with various configurations - Environment variable handling (REDIS_HOST, REDIS_PORT, etc.) - Global Redis client reuse functionality - Error handling for invalid configuration values - Improves coverage for src/backends/index.ts to 100%
…d interfaces - Verify interface completeness and optional properties - Test all log event types coverage - Ensures TypeScript type exports are properly accessible - Improves overall type safety coverage
… Add tests for all Redis operations (get, set, del, lock, unlock, clear) - Test serialization/deserialization error scenarios - Test prefix handling and configuration edge cases - Test non-Error object handling in Redis operations - Improves coverage for src/backends/redis.ts to 100%
…- Add extensive error handling tests for backend operations - Test stale cache error scenarios (set/get failures) - Test polling during lock wait with error conditions - Test various prefix/version combinations and edge cases - Improves coverage for src/cache/createCacheHandler.ts
…ests for default handler path vs custom backend path - Test temporary handler creation with custom backend - Add error scenarios and edge cases - Improves coverage for src/cache/fetchWithCache.ts to 100%
…tests for items without options, with only TTL, with only staleTtl - Test invalid input handling (null, undefined, empty arrays) - Enhanced clearCache error scenarios - Improves coverage for src/instrumentation/index.ts to 100%
…atterns for coverage - Exclude test files, examples, node_modules, coverage reports - Include only src/**/*.ts files for accurate coverage reporting
…rom 'npx c8 vitest run' to 'npx vitest run --coverage' - Ensures proper coverage configuration from vitest.config.ts is used - Fixes coverage reporting accuracy
…r' branch (main repository branch) - Add 'coverage' branch to push triggers - Maintain compatibility with 'main' and 'feature/*' branches - Fixes Codecov integration by ensuring CI runs on correct branches
…4 to 3.2.2 for better coverage reporting - Includes related package-lock.json updates
… 'master' branch in Codecov badge URL - Ensures badge shows correct coverage status for the actual main branch
…er type assertions - Fix unused parameter warnings - Remove unused type imports - Ensure all tests pass linting requirements
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
…t timeouts in fetchWithCache.test.ts to prevent CI failures - fix package.json coverage script to use vitest instead of c8 - add explicit testTimeout configuration to vitest.config.ts
There was a problem hiding this comment.
Bug: CI Trigger Mismatch Causes Integration Failures
The CI workflow was updated to trigger on the master branch instead of main. If main is the repository's default branch, this will prevent CI from running on pushes/PRs, breaking continuous integration for the primary development branch. The README's Codecov badge URL was similarly updated.
.github/workflows/ci.yml#L4-L7
next-cachex/.github/workflows/ci.yml
Lines 4 to 7 in 7c2ff14
Was this report helpful? Give feedback by reacting with 👍 or 👎
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.