Conversation
High-levelNice addition. The SEARCH_MODE switch with a clean fallback to Fumadocs, the title map for better labels, and the SearchDialog SDK dropdown/debounce UX are all solid. Blockers
const { search, setSearch, query } = useDocsSearch({
type: 'fetch',
- api: '/docs/api/search'
+ api: '/api/search'
}, undefined, selectedSdk || undefined, SEARCH_DEBOUNCE_MS);- const { search: defaultSearch, setSearch: defaultSetSearch, query } = useDocsSearch({ type: 'fetch', api: '/docs/api/search' });
+ const { search: defaultSearch, setSearch: defaultSetSearch, query } = useDocsSearch({ type: 'fetch', api: '/api/search' });
// scripts/generate-title-map.ts
import fg from 'fast-glob';
// ...
const files = await fg('**/*.{md,mdx}', { cwd: contentDir, absolute: false });Suggestions (non-blocking)
const seen = new Set<string>();
// before pushing
if (seen.has(url)) continue;
seen.add(url);
Test plan
If you want, I can push the two essential fixes (API path + fast-glob swap). Learn more about Cursor Agents |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| import fs from 'fs'; | ||
| import path from 'path'; | ||
| import { glob } from 'glob'; | ||
|
|
There was a problem hiding this comment.
Declare dependency for glob used in title map script
The new title map generator imports glob but package.json still has no glob dependency. Because build:prep now runs tsx scripts/generate-title-map.ts before every build/dev, a fresh install will raise Cannot find module 'glob' under bun/pnpm (which do not allow undeclared transitive deps). Add glob (or switch to the existing fast-glob) to the manifest to avoid a build-prep failure.
Useful? React with 👍 / 👎.
No description provided.