Open
Conversation
자가 인증서에 대한 브라우저 차단으로 인해 http 요청을 리다이렉트하지 않고 직접 서빙하게 변경 -> 개발 단계에서 브라우저에서 테스트 하기 위해
There was a problem hiding this comment.
Pull Request Overview
This PR removes the HTTPS redirection in favor of directly serving HTTP requests to improve developer convenience in local environments.
- Removed 301 HTTPS redirects and added multiple proxy_pass configurations in the HTTP server block for various endpoints
- Updated CORS headers to restrict allowed origins specifically to http://localhost:3000
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| nginx.conf | Updated HTTP server block with direct proxy_pass settings |
| cors-headers.conf | Modified CORS headers to allow origin http://localhost:3000 |
Comments suppressed due to low confidence (1)
cors-headers.conf:3
- Ensure that limiting the allowed origin to http://localhost:3000 is intended only for development; consider implementing an environment-based configuration to prevent potential issues in production.
add_header 'Access-Control-Allow-Origin' 'http://localhost:3000' always;
Comment on lines
+110
to
+118
| # # HTTP 서버 블록 | ||
| # server { | ||
| # listen 80; | ||
|
|
||
| # location / { | ||
| # include /etc/nginx/common/cors-headers.conf; | ||
| # return 301 https://$host$request_uri; | ||
| # } | ||
| # } |
There was a problem hiding this comment.
If the old HTTP redirection block is no longer required, consider removing these commented lines to reduce clutter in the configuration.
Suggested change
| # # HTTP 서버 블록 | |
| # server { | |
| # listen 80; | |
| # location / { | |
| # include /etc/nginx/common/cors-headers.conf; | |
| # return 301 https://$host$request_uri; | |
| # } | |
| # } | |
| # (Removed the commented-out HTTP server block to reduce clutter) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔧 변경 내용 (What)
기존에 HTTP 요청을 HTTPS로 리다이렉트하던 로직을 제거하고,
HTTP 요청도 직접 서빙하도록 변경했습니다.
🎯 변경 배경 (Why)