Always handle energy in microwatt-hours#31
Merged
superm1 merged 3 commits intosuperm1:masterfrom Mar 16, 2026
Merged
Conversation
If a battery only provides capacity values in microamp-hours, convert charge to energy by multiplying by the battery's design voltage. Fixes superm1#29
malsyned
force-pushed
the
issue-29-charge-energy
branch
from
c2ffbe1 to
04e6ac9
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #31 +/- ##
==========================================
+ Coverage 85.72% 85.91% +0.19%
==========================================
Files 34 34
Lines 7620 7655 +35
Branches 722 723 +1
==========================================
+ Hits 6532 6577 +45
+ Misses 871 866 -5
+ Partials 217 212 -5 ☔ View full report in Codecov by Sentry. |
…tency I used GREEK SMALL LETTER MU (μ) in the docstring for _get_design_voltage(), but the rest of the codebase uses MICRO SIGN (µ) everywhere.
superm1
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a battery only provides capacity values in microamp-hours, convert charge to energy by multiplying by the battery's design voltage.
Fixes #29