build: switch to substrait-antlr

[vbarua]

Generated ANTLR code can now be found in the substrait-antlr package

BREAKING CHANGE: module substrait.gen.antlr has been removed

[vbarua]

TestPyPI is having issues. Instead of publishing substrait-antlr to TestPyPI, I published https://pypi.org/project/vbarua-substrait-antlr/0.79.0/ from my own branch in https://github.com/vbarua/substrait-packaging/tree/python/substrait-antlr/v0.79.0 so that we can see how this integrates.

If this looks reasonable, I can update substrait-packaging to publish substrait-antlr and then update this PR.

[tokoko]

wouldn't it be better to do a version check during runtime? at the top of the root init.py for example?

[vbarua]

What would be the advantage of doing this at runtime? I guess it would prevent users from using mismatched versions in their own projects, even if we explicitly pin them in substrait-python?

[tokoko]

yeah, I'm thinking of a scenario where different dependencies pull in different versions, for example if protobuf veresion is pinned and antlr version is latest. I'm not even exactly sure whether we should disallow it, but at least some sort of a warning is probably needed. feel free to disregard it though, hardly a problem we need to solve today.

[vbarua]

I'm not even exactly sure whether we should disallow it, but at least some sort of a warning is probably needed.

A think a warning would be reasonable, but like you say I think it's something we can add in later. I imagine the primary way that people are pulling in these dependencies will be via substrait-python directly, and once we finish with the codegen automation and packaging we should be able to keep substrait-python up-to-date with spec changes, which should minimize the need for folks to pull in their own versions of the artifacts.

[nielspardon]

LGTM

[vbarua]

PR to release substrait-antlr to PyPI substrait-io/substrait-packaging#9