Conversation
…neko, sophora-media-finder, and sophora-schema-docs Co-authored-by: DanielRaapDev <10845365+DanielRaapDev@users.noreply.github.com>
Co-authored-by: DanielRaapDev <10845365+DanielRaapDev@users.noreply.github.com>
Co-authored-by: DanielRaapDev <10845365+DanielRaapDev@users.noreply.github.com>
|
@copilot The tests could be extended to also validate that the checksum does not change when annotations of the configmap like the helm chart version changes. Only when values affecting the data of the ConfigMap the checksum value needs to be different. |
…itivity Co-authored-by: DanielRaapDev <10845365+DanielRaapDev@users.noreply.github.com>
Extended the tests in 4ec4ae6 for all three charts. Each chart now has three additional test cases:
|
There was a problem hiding this comment.
Pull request overview
This PR updates three Helm charts to automatically trigger pod rollouts when their rendered ConfigMap data changes, by adding a checksum/config annotation to the pod template. It also bumps chart versions, adds Artifact Hub changelog entries, and introduces helm-unittest coverage to ensure the checksum is stable across metadata-only changes (like release name) while still changing on data updates.
Changes:
- Add
checksum/configpod-template annotations ino-neko,sophora-media-finder, andsophora-schema-docs, hashing ConfigMap.dataonly. - Bump chart versions and update
artifacthub.io/changesentries accordingly. - Add helm-unittest tests verifying checksum stability across release name changes and variability when ConfigMap data changes; add
podAnnotations: {}tosophora-media-finder.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| charts/sophora-schema-docs/templates/deployment.yaml | Adds checksum/config annotation based on ConfigMap .data to trigger rollouts on config changes. |
| charts/sophora-schema-docs/tests/checksum_test.yaml | Adds tests for checksum presence, metadata-stability, and data-change sensitivity. |
| charts/sophora-schema-docs/Chart.yaml | Bumps chart version and updates Artifact Hub changelog entry. |
| charts/sophora-media-finder/templates/deployment.yaml | Adds checksum/config annotation (data-only hash) and supports podAnnotations. |
| charts/sophora-media-finder/tests/checksum_test.yaml | Adds tests for checksum presence, metadata-stability, and data-change sensitivity. |
| charts/sophora-media-finder/values.yaml | Introduces podAnnotations: {} default. |
| charts/sophora-media-finder/Chart.yaml | Bumps chart version and updates Artifact Hub changelog entry. |
| charts/o-neko/templates/deployment.yaml | Adds checksum/config annotation based on ConfigMap .data. |
| charts/o-neko/tests/checksum_test.yaml | Adds tests for checksum presence, metadata-stability, and data-change sensitivity. |
| charts/o-neko/Chart.yaml | Bumps chart version and updates Artifact Hub changelog entry. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
sophora-media-finderdeployment pod templatesophora-schema-docsdeployment pod templateo-nekodeployment pod templatepodAnnotations: {}tosophora-media-findervalues.yamlfromYaml | get "data") to avoid restarts on metadata changes, matching sophora-server patternOriginal prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.