Skip to content

Add class method signatures to TransalationContext #695

Merged
shigoel merged 12 commits intostrata-org:mainfrom
thanhnguyen-aws:methoddecl
Mar 30, 2026
Merged

Add class method signatures to TransalationContext #695
shigoel merged 12 commits intostrata-org:mainfrom
thanhnguyen-aws:methoddecl

Conversation

@thanhnguyen-aws
Copy link
Copy Markdown
Contributor

Description of changes: This PR add Class method signatures into TransalationContext, so inputs (positional & keyword args) of the calls of those methods are parsed correctly.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@thanhnguyen-aws thanhnguyen-aws requested a review from a team March 27, 2026 18:46
@joehendrix
Copy link
Copy Markdown
Contributor

Are there any additional tests we can add to catch regressions? Also can the call site that uses this information to throw an error rather than generate Laurel that will fail typechecking.

@thanhnguyen-aws
Copy link
Copy Markdown
Contributor Author

Are there any additional tests we can add to catch regressions? Also can the call site that uses this information to throw an error rather than generate Laurel that will fail typechecking.
I add a check in line 832. It will throw an error if a function is called with keyword args but missing signature in TranslationContext.

@joehendrix
Copy link
Copy Markdown
Contributor

I'd be good to add a regression test to catch the new error.

joehendrix
joehendrix previously approved these changes Mar 27, 2026
@thanhnguyen-aws thanhnguyen-aws requested a review from shigoel March 30, 2026 17:19
@shigoel shigoel enabled auto-merge March 30, 2026 18:33
@shigoel shigoel added this pull request to the merge queue Mar 30, 2026
Merged via the queue into strata-org:main with commit f9a01de Mar 30, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants