Add class method signatures to TransalationContext #695
Merged
shigoel merged 12 commits intostrata-org:mainfrom Mar 30, 2026
Merged
Add class method signatures to TransalationContext #695shigoel merged 12 commits intostrata-org:mainfrom
shigoel merged 12 commits intostrata-org:mainfrom
Conversation
Contributor
|
Are there any additional tests we can add to catch regressions? Also can the call site that uses this information to throw an error rather than generate Laurel that will fail typechecking. |
Contributor
Author
|
Contributor
|
I'd be good to add a regression test to catch the new error. |
joehendrix
previously approved these changes
Mar 27, 2026
shigoel
reviewed
Mar 30, 2026
shigoel
approved these changes
Mar 30, 2026
joehendrix
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes: This PR add Class method signatures into TransalationContext, so inputs (positional & keyword args) of the calls of those methods are parsed correctly.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.