Fix bug in handling of blocks that occur in expresssions#672
Merged
keyboardDrummer merged 16 commits intomainfrom Mar 30, 2026
Merged
Fix bug in handling of blocks that occur in expresssions#672keyboardDrummer merged 16 commits intomainfrom
keyboardDrummer merged 16 commits intomainfrom
Conversation
joscoh
previously approved these changes
Mar 26, 2026
Contributor
joscoh
left a comment
joscoh
left a comment
There was a problem hiding this comment.
Can you update the PR with a short description of what the bug is?
…org/Strata into fixImpureExpressionBlockHandling
…org/Strata into fixImpureExpressionBlockHandling
joscoh
reviewed
Mar 26, 2026
olivier-aws
reviewed
Mar 27, 2026
StrataTest/Languages/Laurel/Examples/Fundamentals/T2_ImpureExpressions.lean
Show resolved
Hide resolved
joscoh
approved these changes
Mar 30, 2026
olivier-aws
approved these changes
Mar 30, 2026
MikaelMayer
requested changes
Mar 30, 2026
Contributor
MikaelMayer
left a comment
MikaelMayer
left a comment
There was a problem hiding this comment.
The core fix — switching from transformStmt to transformExpr for block handling and fixing the call ordering — looks correct and well-motivated. The new test cases are good. A few items to address below.
StrataTest/Languages/Laurel/Examples/Fundamentals/T2_ImpureExpressions.lean
Show resolved
Hide resolved
MikaelMayer
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
transformStmt, which does not update the substitution map, was being called from insidetransformExprwhen it was handling a block, leading to missing substitutions. A second but smaller bug was a statement ordering bug that occurred when handling calls.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.